Skip to content

BUG: date comparison fails when series is all pd.NaT values #61200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 15, 2025

Conversation

Mohit-Kundu
Copy link
Contributor

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Note also a few builds are failing.

@rhshadrach rhshadrach added Bug Datetime Datetime data dtype Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Mar 30, 2025
@Mohit-Kundu
Copy link
Contributor Author

pre-commit.ci autofix

@Mohit-Kundu
Copy link
Contributor Author

@rhshadrach I just incorporated the changes! Please let me know if everything looks okay.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mohit-Kundu
Copy link
Contributor Author

lgtm

Good to hear! Thank you for guidance :)

@rhshadrach rhshadrach added this to the 3.0 milestone Apr 15, 2025
@rhshadrach rhshadrach changed the title FIX: date comparison fails when series is all pd.NaT values #61188 BUG: date comparison fails when series is all pd.NaT values Apr 15, 2025
@rhshadrach rhshadrach merged commit ec41faa into pandas-dev:main Apr 15, 2025
42 checks passed
@mroeschke
Copy link
Member

Looks like this PR re-added the 1.3MB Pandas Cookbook jpeg into main. Looks like we should hard revert this commit? cc @datapythonista

@datapythonista
Copy link
Member

I'm travelling and I may not be able to do it for several hours or tomorrow. Do you have permissions to access the project settings and enable the force push option? If you can do that, it's aa easy as clone, git reset --soft head~ and git push -f.

If you don't have access, I can see if I can give you permissons, but I don't think I can. Otherwise let's try npt to merge until then, which will make things significantly more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Datetime Datetime data dtype Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: date comparison fails when series is all pd.NaT values
5 participants